Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6765 update GeneralizedDiceLoss #6775

Merged
merged 3 commits into from
Jul 26, 2023
Merged

6765 update GeneralizedDiceLoss #6775

merged 3 commits into from
Jul 26, 2023

Conversation

wyli
Copy link
Member

@wyli wyli commented Jul 25, 2023

Fixes #6765

Description

as discussed in #6765, when batch=True the loss should still return 1 aggregated value instead of C channels. #5466 is not actually achievable with this formulation.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits July 25, 2023 22:57
@wyli
Revert "fix GeneralizedDiceLoss (Project-MONAI#5468)"
8bb0fae 
This reverts commit e03ecd4.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update docstring
b48c53f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and KumoLiu July 25, 2023 22:05
@wyli wyli changed the title update GeneralizedDiceLoss 6765 update GeneralizedDiceLoss Jul 25, 2023
KumoLiu
KumoLiu approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, LGTM.

@wyli
Copy link
Member Author

wyli commented Jul 26, 2023

/build

@wyli wyli enabled auto-merge (squash) July 26, 2023 07:24
@wyli wyli merged commit 6f9cf6b into Project-MONAI:dev Jul 26, 2023
30 of 35 checks passed
@wyli wyli deleted the fixes-6765 branch July 27, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug of GeneralizedDiceLoss
2 participants
@wyli @KumoLiu