Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set data_range as a property #6788

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: set data_range as a property #6788

merged 1 commit into from
Jul 27, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

Fixes #6441

Description

Creates a setter method for data_range by setting it as a property using the @property decorator.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
Copy link
Member

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Member

wyli commented Jul 27, 2023

/build

@wyli wyli enabled auto-merge (squash) July 27, 2023 13:20
@wyli wyli merged commit 11546e8 into Project-MONAI:dev Jul 27, 2023
32 of 37 checks passed
@SauravMaheshkar SauravMaheshkar deleted the saurav/ssim-property branch July 27, 2023 14:08
KumoLiu pushed a commit to KumoLiu/MONAI that referenced this pull request Jul 28, 2023
Fixes Project-MONAI#6441 

### Description

Creates a setter method for `data_range` by setting it as a property
using the **`@property`** decorator.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Saurav Maheshkar <sauravvmaheshkar@gmail.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSIMLoss supports set_data_range
2 participants