Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6907 TORCH_ALLOW_TF32_CUBLAS_OVERRIDE warning and update print #6909

Merged
merged 3 commits into from
Aug 28, 2023
Merged

6907 TORCH_ALLOW_TF32_CUBLAS_OVERRIDE warning and update print #6909

merged 3 commits into from
Aug 28, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Aug 28, 2023 •
edited
Loading

Fixes #6907

Description

  • removes the default warning on TORCH_ALLOW_TF32_CUBLAS_OVERRIDE
  • add debug print info and documentation

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
update print
f3ea64f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update docstring
5dbdd5a 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 6907 update print 6907 TORCH_ALLOW_TF32_CUBLAS_OVERRIDE warning and update print Aug 28, 2023
@wyli
Copy link
Contributor Author

wyli commented Aug 28, 2023

/build

@wyli wyli marked this pull request as ready for review August 28, 2023 09:47
KumoLiu
KumoLiu approved these changes Aug 28, 2023
View reviewed changes
monai/utils/tf32.py Show resolved Hide resolved
@wyli
fixes typo
ef60258 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Aug 28, 2023

/build

@wyli wyli enabled auto-merge (squash) August 28, 2023 10:49
@wyli wyli merged commit 40048d7 into Project-MONAI:dev Aug 28, 2023
33 of 37 checks passed
@wyli wyli deleted the fixes-6907 branch September 2, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KumoLiu KumoLiu KumoLiu approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

by default less warnings for the tf32 flags
2 participants
@wyli @KumoLiu