Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spacing #6912

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Fix Spacing #6912

merged 5 commits into from
Aug 30, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Aug 29, 2023

Fixes #6911.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
@ericspod
Copy link
Member

This appears correct to me, @josiglo would you be able to run your test with this fix to check? If you could, please also try it with your actual data to see if it fixes your production issue. Thanks!

@wyli
Copy link
Member

wyli commented Aug 29, 2023

/build

Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli
Copy link
Member

wyli commented Aug 30, 2023

/build

Copy link
Member

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) August 30, 2023 05:38
@josiglo
Copy link

josiglo commented Aug 30, 2023

Thanks everyone for looking into it so quickly! I ran my tests again including one with the actual data I am using and everything is working as expected with the updated code. Thank you very much for the PR, @KumoLiu!

@wyli
Copy link
Member

wyli commented Aug 30, 2023

/build

@wyli wyli merged commit 6f5005f into Project-MONAI:dev Aug 30, 2023
33 of 37 checks passed
@KumoLiu KumoLiu deleted the fix-spacing branch August 30, 2023 14:18
KumoLiu added a commit to KumoLiu/MONAI that referenced this pull request Aug 30, 2023
Fixes Project-MONAI#6911.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacingd changes the output shape unexpectedly
4 participants