Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid FutureWarning in CropForeground #6934

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Avoid FutureWarning in CropForeground #6934

merged 3 commits into from
Sep 4, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 4, 2023 •
edited

Fixes #6685 .

Description

Change the default value of allow_smaller to False where CropForeground is used to avoid FutureWarning.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6685
1558bf8 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu changed the title fix #6685 Avoid FutureWarning in CropForeground Sep 4, 2023
@KumoLiu
minor fix
8b9f2aa 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
fbc8290 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Member

wyli commented Sep 4, 2023

/build

@wyli wyli enabled auto-merge (squash) September 4, 2023 07:56
@wyli wyli merged commit cb4f517 into Project-MONAI:dev Sep 4, 2023
33 of 37 checks passed
@KumoLiu KumoLiu deleted the cropforeground branch September 4, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cropforeground with margin>0
2 participants
@KumoLiu @wyli