Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ckpt_export #6965

Merged
merged 14 commits into from
Sep 11, 2023
Merged

Improve ckpt_export #6965

merged 14 commits into from
Sep 11, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 8, 2023

Fixes #6953

Description

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#6953
bd918eb 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
2884928 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into ckp…
fc9cc21 
…t-export
@KumoLiu
add unittests
cf415b0 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu marked this pull request as ready for review September 11, 2023 10:13
KumoLiu
KumoLiu commented Sep 11, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
@KumoLiu
update docstring
abd83e1 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
update unittests
5eefa2c 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
feecd1f 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix flake8
f272778 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli reviewed Sep 11, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
@KumoLiu
address comments
1f5a26e 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
address comments
cb4e63e 
Signed-off-by: KumoLiu <yunl@nvidia.com>
wyli
wyli approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Member

wyli commented Sep 11, 2023

/build

@wyli wyli enabled auto-merge (squash) September 11, 2023 12:16
ericspod
ericspod reviewed Sep 11, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
ericspod
ericspod reviewed Sep 11, 2023
View reviewed changes
monai/bundle/scripts.py Outdated Show resolved Hide resolved
ericspod
ericspod approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I had a few minor changes for error messages but otherwise this looks like a good solution.

@wyli wyli disabled auto-merge September 11, 2023 13:18
KumoLiu and others added 3 commits September 11, 2023 21:20
@KumoLiu @ericspod
Update monai/bundle/scripts.py
39fd68d 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu @ericspod
Update monai/bundle/scripts.py
d821498 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
fix flake8
4cccaa2 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli
Copy link
Member

wyli commented Sep 11, 2023

/build

@wyli wyli enabled auto-merge (squash) September 11, 2023 13:40
@wyli wyli merged commit 5fd23b8 into Project-MONAI:dev Sep 11, 2023
30 of 35 checks passed
@KumoLiu KumoLiu deleted the ckpt-export branch September 12, 2023 02:54
@KumoLiu KumoLiu mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod ericspod approved these changes

@binliunls binliunls binliunls approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Converting to Torchscript
4 participants
@KumoLiu @wyli @ericspod @binliunls