Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docstring and typehint for epoch_log and iteration_log in TensorBoardStatsHandler #7027

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Update docstring and typehint for epoch_log and iteration_log in TensorBoardStatsHandler #7027

merged 4 commits into from
Sep 22, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 22, 2023

Fixes #7026.

Description

Update docstring and type-hint for epoch_log and iteration_log in TensorBoardStatsHandler

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 3 commits September 22, 2023 15:49
@KumoLiu
fix Project-MONAI#7026
890e3c1 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
6a58965 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'dev' into epoch-log
8a81510
@wyli
Copy link
Member

wyli commented Sep 22, 2023

/build

@wyli wyli enabled auto-merge (squash) September 22, 2023 10:02
@wyli wyli merged commit 0d1337e into Project-MONAI:dev Sep 22, 2023
30 of 35 checks passed
@KumoLiu KumoLiu deleted the epoch-log branch September 22, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unclear statement of epoch_log and iteration_log in TensorBoardStatsHandler
2 participants
@KumoLiu @wyli