Adding padding option to autoencoder #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More or less copied from monai/blocks/convolutions.py DCO Remediation Commit for Jupilogy <j.dick@lboro.ac.uk> I, Jupilogy <j.dick@lboro.ac.uk>, hereby add my Signed-off-by to this commit: 0e0d5e9 I, Jupilogy <j.dick@lboro.ac.uk>, hereby add my Signed-off-by to this commit: dec2b99 I, Jupilogy <j.dick@lboro.ac.uk>, hereby add my Signed-off-by to this commit: e322d1d Signed-off-by: Jupilogy <j.dick@lboro.ac.uk>
|
/build |
wyli
approved these changes
Sep 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7045 .
Description
Added "padding" option to
monai/network/nets/autoencoder.pysuch that the conv and residual units will be passed the padding option.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.Notes
I haven't been able to run the
./runtests.sh, even tried running./runtests.sh -hand got no output (no error or anything). I guess I don't have permissions to run.shfiles on this machine. However the changes are very small and default to previous functionality so unless somebody passes a padding argument, this should not break existing usage of the function.