Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code formatting for user specified directories #7106

Merged
merged 8 commits into from
Oct 9, 2023
Merged

Code formatting for user specified directories #7106

merged 8 commits into from
Oct 9, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 9, 2023

Fixes #7099

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

KumoLiu and others added 3 commits October 9, 2023 15:47
@KumoLiu
fix Project-MONAI#7099
738179e 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'dev' into format
5933ce1
@KumoLiu
update
8bfd087 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu marked this pull request as ready for review October 9, 2023 08:08
wyli
wyli reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I have some minor comments inline please help test different use cases

runtests.sh Show resolved Hide resolved
runtests.sh Outdated Show resolved Hide resolved
@KumoLiu
address comments
571b62b 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'dev' of https://github.com/Project-MONAI/MONAI into format
374933b
@KumoLiu
update
fe05820 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
add setup.cfg
ee906f6 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
rm ruff support
120d5b6 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli
Copy link
Member

wyli commented Oct 9, 2023

/build

@wyli wyli enabled auto-merge (squash) October 9, 2023 18:16
@wyli wyli merged commit 5c6d199 into Project-MONAI:dev Oct 9, 2023
31 checks passed
@KumoLiu KumoLiu deleted the format branch October 10, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

making ./runtests.sh --autofix available for user specified directories other than pwd
2 participants
@KumoLiu @wyli