Geometric transforms proposals - Flip #7385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nic-Ma
reviewed
Jan 17, 2024
monai/transforms/spatial/array.py
Outdated
| self.kwargs = kwargs | ||
| self.spatial_axis = spatial_axis | ||
| self.operators: list[Operator] = [] | ||
| for r in SUPPORTED_OPERATORS: # set predefined operators as default |
There was a problem hiding this comment.
Do you mean to put all kinds of operators (flip, rotate, crop, etc.) in this SUPPORTED_OPERATORS? for-loop all the operators in every transform?
Thanks.
Nic-Ma
reviewed
Jan 17, 2024
monai/transforms/spatial/operator.py
Outdated
| """ | ||
| raise NotImplementedError(f"Subclass {self.__class__.__name__} must implement this method.") | ||
|
|
||
| class FlipImageOp(Operator): |
There was a problem hiding this comment.
I don't see how to use these operators in this PR.
Thanks.
7 tasks
Part of Project-MONAI#7486 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4027
Description
In this draft PR, I have two proposals about how to add geometric transforms.
One is that assume the operation on different objects as different operators. Users can also specify their operators.
The Other one separate the flip images and flip points to Two transforms.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.