-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Geometric Transforms #7386
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
for more information, see https://pre-commit.ci
return img | ||
|
||
|
||
class ImageIntensityAndAnnotation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the MONAI transforms should inherit and follow the base signature, @ericspod @atbenmurray what do you think?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should in general, yes, but this is a prototype for discussion so I don't think it's a problem. Maybe the PR should be draft so it's clear we aren't proposing things as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that Github doesn't appear to like the huge base64 blob that's in this file. It's one long line that's making it impossible to view the file or its delta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I will try to upload another json file. But I dont think you need to view the json file as it contains that blob which is a result from labelme. I just dont use that part. I can remove it and reupload the file tomorrow.
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu>
for more information, see https://pre-commit.ci
Signed-off-by: Vikash Gupta <write2vikash@gmail.com>
for more information, see https://pre-commit.ci
Added my thoughts after the 2/7 meeting. Signed-off-by: Vikash Gupta <write2vikash@gmail.com>
for more information, see https://pre-commit.ci
Part of Project-MONAI#7486 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Fixes # .
Description
This pull request produces few Geometric transforms implementation along with some example code.
The added transforms are
LoadImageAndAnnotations
FlipImageAndAnnotations
RotateImageAndAnnotations
ResampleImageAndAnnotations
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.