-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7540 change bundle workflow args #7549
Merged
KumoLiu
merged 22 commits into
Project-MONAI:dev
from
yiheng-wang-nv:add-bundleworkflow-arg
Apr 1, 2024
Merged
7540 change bundle workflow args #7549
KumoLiu
merged 22 commits into
Project-MONAI:dev
from
yiheng-wang-nv:add-bundleworkflow-arg
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…NAI into add-bundleworkflow-arg
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
ericspod
reviewed
Mar 21, 2024
ericspod
reviewed
Mar 21, 2024
ericspod
reviewed
Mar 21, 2024
ericspod
reviewed
Mar 21, 2024
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…NAI into add-bundleworkflow-arg
for more information, see https://pre-commit.ci
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…NAI into add-bundleworkflow-arg
ericspod
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
For the CI error, may add something like this: MONAI/monai/bundle/workflows.py Line 171 in bca11a5
|
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
…NAI into add-bundleworkflow-arg
/build |
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7540 .
Description
This PR:
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.