Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix negative strides issue in NrrdReader #7809

Merged
merged 3 commits into from
May 28, 2024
Merged

Fix negative strides issue in NrrdReader #7809

merged 3 commits into from
May 28, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented May 27, 2024

Fixes #7798

Description

Add copy to avoid negative strides when save spatial shape.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
Fix Project-MONAI#7798
afd73f0 
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu KumoLiu requested review from ericspod and Nic-Ma May 27, 2024 09:19
ericspod
ericspod approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for small things like metadata, thanks!

@ericspod ericspod enabled auto-merge (squash) May 28, 2024 14:22
@KumoLiu
Copy link
Contributor Author

KumoLiu commented May 28, 2024

/build

@ericspod ericspod merged commit a0935d9 into Project-MONAI:dev May 28, 2024
28 checks passed
@KumoLiu KumoLiu deleted the collate branch May 29, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Negative strides issue in monai.transforms.LoadImage causes error during collate
2 participants
@KumoLiu @ericspod