Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated scipy.ndimage namespaces in optional imports #7847

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

alkamid
Copy link
Contributor

@alkamid alkamid commented Jun 14, 2024

Fixes #7677 .

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.

Signed-off-by: alkamid <adam.klimont@cydar.co.uk>
Signed-off-by: alkamid <adam.klimont@cydar.co.uk>
@alkamid alkamid marked this pull request as ready for review June 14, 2024 10:39
@ericspod ericspod requested a review from KumoLiu June 17, 2024 14:28
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look good to me. We need to run the last of our CICD tests however.

@ericspod ericspod requested a review from Nic-Ma June 17, 2024 14:30
@KumoLiu
Copy link
Contributor

KumoLiu commented Jun 24, 2024

/build

Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, LGTM.

@KumoLiu KumoLiu merged commit e801540 into Project-MONAI:dev Jun 25, 2024
28 checks passed
guopengf pushed a commit to guopengf/MONAI that referenced this pull request Jun 26, 2024
…ct-MONAI#7847)

Fixes Project-MONAI#7677 .

### Description

A few sentences describing the changes proposed in this pull request.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.

---------

Signed-off-by: alkamid <adam.klimont@cydar.co.uk>
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
Signed-off-by: Pengfei Guo <pengfeig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated namespace in scipy
3 participants