Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to match Numpy 2.0 requirements #7857

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

ericspod
Copy link
Member

@ericspod ericspod commented Jun 17, 2024

DRAFT PR. There are too many changes for Numpy compatibility to do right now, see next PR which fixes Numpy version.

Fixes #7856.

Description

Adjusts the MAX_SEED value to be compatible with Numpy 2.0 behaviour changes.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
ericspod and others added 3 commits June 17, 2024 15:11
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod mentioned this pull request Jun 17, 2024
7 tasks
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
@ericspod ericspod changed the title Updating use of MAX_SEED to match Numpy 2.0 requirements Updating to match Numpy 2.0 requirements Jun 17, 2024
@ericspod ericspod marked this pull request as draft June 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numpy 2.0 Behaviour Changes
1 participant