Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] The Packager should create in the MAP the env var. MONAI_MODELPATH, with default #382

Closed
MMelQin opened this issue Oct 30, 2022 · 0 comments · Fixed by #381
Closed
Assignees
Labels
enhancement New feature or request

Comments

@MMelQin
Copy link
Collaborator

MMelQin commented Oct 30, 2022

Is your feature request related to a problem? Please describe.
In the MONAI App Package, the models are placed in /opt/monai/models, and there is a env var per spec, MONAI_MODELPATH, whose default is set to the path of this folder. The application on startup, read this env var to find the folder to load the model files.

The Packager, for unknown reason, did not create this env var in the MAP container image, maybe it was expecting the defunct executor to manage this. In any case, to run the MPA as an container, the env var has to be passed in, even though the models are internal knowledge of the MAP, and the model default path need not be fiddled with.

Describe the solution you'd like
Add the step to create the env var, MONAI_MODELPATH with the default value /opt/monai/models, in the Dockerfile to generate the MAP.

Describe alternatives you've considered
The env var has to be passed in on docker run, e.g.
-e MONAI_MODELPATH="/opt/monai/models"

Additional context
All other env vars called for by the spec exist in the container image with the expected default.

@MMelQin MMelQin added the enhancement New feature or request label Oct 30, 2022
@MMelQin MMelQin self-assigned this Oct 30, 2022
@MMelQin MMelQin added this to To do in v1.0.0 via automation Oct 30, 2022
@MMelQin MMelQin moved this from To do to In progress in v1.0.0 Oct 30, 2022
@MMelQin MMelQin moved this from In progress to Done in v1.0.0 Nov 3, 2022
@MMelQin MMelQin removed this from Done in v1.0.0 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant