Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Packager to make the MAP more secure, easier to use, and based on new version of PyTorch image for newer CUDA versions. #381

Merged
merged 9 commits into from Nov 3, 2022

Conversation

MMelQin
Copy link
Collaborator

@MMelQin MMelQin commented Oct 25, 2022

This PR intends to improve the packager itself, as well as making the MAP based on newer if not the latest PyTorch image, by default, to make use of newer version of CUDA.

  • Packager creates the env var in the MAP image, with the default value being the path specified in the spec. This will eliminate the need to provide the env var when docker run. But the MONAI_MODELPATH was missing. Hence added
  • Resolve a minor security risks where /tmp is used for temp file in the Packager
  • The default PyTorch image is now nvcr.io/nvidia/pytorch:22.08-py3, which is the last version that still supports Nvidia Driver release 515 (or later). Also, this base has PyTorch 1.13
  • The minimal version of NumPy is bumped to 1.21.6, the latest version still compatible with Python 3.7, which is still supported by App SDK.
  • Fixed a imshow issue in the simple_app Jupyter Notebook
  • Tested all example apps and notebooks, both local execution as well as in MAP

Signed-off-by: M Q mingmelvinq@nvidia.com

@MMelQin MMelQin linked an issue Oct 26, 2022 that may be closed by this pull request
@MMelQin MMelQin self-assigned this Oct 26, 2022
@MMelQin MMelQin added this to In progress in v1.0.0 Oct 26, 2022
@MMelQin MMelQin force-pushed the mqin/issue_359_support_newer_CUDA branch from cc88578 to 2251e9a Compare October 28, 2022 05:17
@MMelQin MMelQin changed the title WIP: Update the default base image to 22.08 version Enhance Packager to make the MAP more secure, easier to use, and based on new version of PyTorch image for newer CUDA versions. Oct 30, 2022
Signed-off-by: M Q <mingmelvinq@nvidia.com>
… version

Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
@MMelQin MMelQin force-pushed the mqin/issue_359_support_newer_CUDA branch from cabce85 to 8026812 Compare October 30, 2022 05:32
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MMelQin MMelQin moved this from In progress to Review in progress in v1.0.0 Nov 2, 2022
@MMelQin MMelQin merged commit 9113c93 into main Nov 3, 2022
@MMelQin MMelQin moved this from Review in progress to Done in v1.0.0 Nov 3, 2022
@MMelQin MMelQin deleted the mqin/issue_359_support_newer_CUDA branch March 17, 2023 20:55
@MMelQin MMelQin removed this from Done in v1.0.0 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants