Bump numpy >= 1.20 to avoid MKL error in conda env, and add --upgrade for pip install app sdk #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all monai-deploy-app-sdk Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
gigony
approved these changes
Nov 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was found out that when running Jupyter-lab within a environment set up using conda, pytorch encountered error related to MKL, see pytorch issue.
A previous PR modified the Jupyter notebook adding env var ['MKL_THREADING_LAYER'] = 'GNU' to work around the MKL issue, which is one of the suggested fixes.
A cleaner fix, as also stated in the said issue, is to upgrade to numpy 1.20 to avoid the MKL issue without needing the env var workaround.
The example segmentation examples had already been tested with numpy >= 1.20, so it is the safe and correct fix to bump the numpy version >= 1.20, in the apps, as well as in the Jupyter notebooks that copied the app code.
Also added
--upgradeoption for pip install monai-deploy-app-sdk, in case the env had an earlier version of the sdk installed.