Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Address typos in bilinear mode usage in Spacingd operator #271

Merged
merged 1 commit into from Feb 25, 2022

Conversation

swederik
Copy link
Contributor

There is a typo in the use of the Spacing transform which causes some issues in the examples:

It's supposed to be bilinear instead of blinear

See:
https://github.com/Project-MONAI/MONAI/blob/05013c756db7b10ae9ac524cc2a7e68d75c6b693/monai/transforms/spatial/array.py#L354

Thanks!

Signed-off-by: Erik <erik.ziegler@radicalimaging.com>
@dbericat dbericat added bug Something isn't working good first issue Good for newcomers labels Feb 25, 2022
@dbericat dbericat added this to In progress in v0.3.0 via automation Feb 25, 2022
@dbericat
Copy link
Member

Thanks @swederik ! Nice catch. LGTM!

@MMelQin ?

@MMelQin
Copy link
Collaborator

MMelQin commented Feb 25, 2022

@swederik thank you for the catch and fix. Indeed, when "semi-automatically" creating the inference app, the inference config file was not copied over correctly. With the upcoming MONAI model package, transferring the inference config from training validation to deploy should be automated, one of its design goals is to avoid this type of error.

The following are the supported modes of SpacingD transform.

mode: {``"bilinear"``, ``"nearest"``}
                Interpolation mode to calculate output values. Defaults to ``"bilinear"``. 

@MMelQin MMelQin moved this from In progress to Reviewer approved in v0.3.0 Feb 25, 2022
@MMelQin MMelQin merged commit 0fa444c into Project-MONAI:main Feb 25, 2022
@MMelQin MMelQin moved this from Reviewer approved to Done in v0.3.0 Feb 25, 2022
@MMelQin MMelQin mentioned this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants