Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement highdicom seg operator #327

Merged
merged 9 commits into from Aug 18, 2022
Merged

Implement highdicom seg operator #327

merged 9 commits into from Aug 18, 2022

Commits on Aug 15, 2022

  1. Implement highdicom seg operator 

    Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com>
    @CPBridge
    CPBridge committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    1fd64e9 View commit details
    Browse the repository at this point in the history

  2. Formatting fixes 

    Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com>
    @CPBridge
    CPBridge committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    5ce872c View commit details
    Browse the repository at this point in the history

  3. Typing fixes 

    Signed-off-by: Chris Bridge <chrisbridge44@googlemail.com>
    @CPBridge
    CPBridge committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    8d2afe8 View commit details
    Browse the repository at this point in the history

  4. Update the Spleen App to use HighDicom Seg Writer. 

    The app is still not compatible with monai v0.9.1 as the app testing
revealed that to its Invert transform failed resample the predicted
image back to input image spacings. Also, the new Seg Writer impl is
strict on DICOM attribute VR conformance, and would throw exception
when the input DICOM instances have non-conformant attribute VR values.

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
    @MMelQin
    MMelQin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    dd02bb8 View commit details
    Browse the repository at this point in the history

  5. Fix isort error for ordering of imports 

    Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
    @MMelQin
    MMelQin committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    f2832f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Update doc strings and comments for seg label and algorithm name and … 

    …version

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
    @MMelQin
    MMelQin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    0cbf368 View commit details
    Browse the repository at this point in the history

  2. Pin moani==0.9.0 for now as 0.9.1 causes issues. Also pydicom to 2.3.0 

    as the use of highdicom require pydicom>=2.3.0

Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
    @MMelQin
    MMelQin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d1bb6cf View commit details
    Browse the repository at this point in the history

  3. Updated apps that have multiple segments 

    Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
    @MMelQin
    MMelQin committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    f9b151d View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Found the few missing codes, so avoided use of generic "Organ" 

    Signed-off-by: mmelqin <mingmelvinq@nvidia.com>
    @MMelQin
    MMelQin committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    b4eb36d View commit details
    Browse the repository at this point in the history