Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose option to omit empty frames #401

Merged
merged 1 commit into from Dec 7, 2022
Merged

Conversation

CPBridge
Copy link
Collaborator

@CPBridge CPBridge commented Dec 7, 2022

As discussed in the working group, expose the option to set omit_empty_frames to False in the dicom segmentation writer operator to workaround issues with some viewers (e.g. OHIF).

Addresses #397 @hossam99-9 @GreySeaWolf

Signed-off-by: Chris Bridge <cbridge@partners.org>
@CPBridge CPBridge added the enhancement New feature or request label Dec 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@MMelQin MMelQin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MMelQin MMelQin linked an issue Dec 7, 2022 that may be closed by this pull request
@MMelQin MMelQin added this to Reviewer approved in v1.0.0 Dec 7, 2022
@CPBridge CPBridge merged commit 42bec18 into main Dec 7, 2022
@MMelQin MMelQin removed this from Reviewer approved in v1.0.0 Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Problem with dicom_seg_writer_operator
2 participants