New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option for SimpleInferer #428
Conversation
@MMelQin Including |
Yes, needs to define the class of type StrEnum before using it. Will suggest some code. |
Hi @MMelQin, But I don't know how this will help or enhance the existing code. Please let me know and I will fix it. |
Another issue is that the MD App SDK requires Python version >= 3.7, for which the StrEnum is NOT available. This is why MONAI Core had its impl of StrEnum, as Eric mentioned. For our use case, the relevant magic strings had not been used in the App SDK or app code, I think we can safely use Enum or IntEnum for now. However, the monai.utils.enums.py has already ported the StrEnum and noticed this class is already imported and used in this change, we'll use StrEnum. I have pushed a couple changes to define and use the InfererType StrEnum along with updating a couple more arguments, as well as updating the app code to demonstrate the use of the InfererType. Please also try out the update with your simple inference application. |
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu> Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu> Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu> Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: Vikash Gupta <gupta.vikash@mayo.edu> Signed-off-by: M Q <mingmelvinq@nvidia.com>
Signed-off-by: M Q <mingmelvinq@nvidia.com>
b751c60
to
3437977
Compare
Signed-off-by: M Q <mingmelvinq@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: M Q <mingmelvinq@nvidia.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Added an option for SimpleInferer on monai_seg_inference_operator.py