Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

191 background timeout service #297

Merged
merged 27 commits into from
Aug 12, 2022
Merged

191 background timeout service #297

merged 27 commits into from
Aug 12, 2022

Conversation

lillie-dae
Copy link
Collaborator

Description

Implements #191 .

Changes required to implement task cancelation requests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@lillie-dae
background worker for timeouts
bd098c1 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
background worker for timeouts
986a873 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop
da5cd28 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
minor fix
dcab4f4 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
headers and some tests
0118123 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
headers and some tests
4e36c54 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
added tests
2d6423a 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
added BackgroundServiceSettings, added Append extension and tests add…
a88afdf 
…ed passing IdentityKey

Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
added BackgroundServiceSettings
42aff11 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae lillie-dae self-assigned this Aug 8, 2022
@lillie-dae
Merge branch 'develop' of https://github.com/Project-MONAI/monai-depl…
c5b21bf 
…oy-workflow-manager into 191-background-cleanup-service
@lillie-dae
update messaging package
80c02e4 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop - conflicts
d480da2 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop - conflicts
04e8dee 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop - minor fix
b1f216f 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop - minor fix
b571f6d 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop - header fix
b797f7e 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
merge in develop
e1684a6 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
minor fix
fcb4348 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
removed comments
1173d4b 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
dates 😡😡😡
69c869e 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
dates again
819a1de 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
dates again!
a2f25f9 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
changed date assertions so no more issues with dates in tests
6a4e12a 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@lillie-dae
minor fixs
dd55258 
Signed-off-by: Lillie Dae <lillie.dae@answerdigital.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 180 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@lillie-dae lillie-dae merged commit 4fa3292 into develop Aug 12, 2022
@mocsharp mocsharp deleted the 191-background-cleanup-service branch June 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocsharp mocsharp mocsharp left review comments

@jackschofield23 jackschofield23 jackschofield23 approved these changes

@neildsouth neildsouth Awaiting requested review from neildsouth

Assignees

@lillie-dae lillie-dae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lillie-dae @mocsharp @jackschofield23