Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task manager dockerfile #309

Merged
merged 5 commits into from
Aug 9, 2022
Merged

add task manager dockerfile #309

merged 5 commits into from
Aug 9, 2022

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Aug 9, 2022 •
edited

Signed-off-by: Jack Schofield jack.schofield@answerdigital.com

Description

Fixes # .

Adds a docker file for the task manager

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 changed the title add task add task manager dockerfile Aug 9, 2022
@jackschofield23 jackschofield23 marked this pull request as ready for review August 9, 2022 13:40
@jackschofield23
add task
4746410 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
test
642c655 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
update
8501d4b 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
ok
8771be4 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@jackschofield23
category
6a93b7f 
Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
RemakingEden
RemakingEden approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@RemakingEden RemakingEden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jackschofield23 jackschofield23 merged commit 26b9f21 into develop Aug 9, 2022
@jackschofield23 jackschofield23 deleted the addtaskmanagerdocker branch August 9, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemakingEden RemakingEden RemakingEden approved these changes

@mocsharp mocsharp Awaiting requested review from mocsharp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jackschofield23 @RemakingEden