Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Docker Plugin in Task Manager. #398

Merged
merged 12 commits into from
Sep 12, 2022

Conversation

pritishnahar95
Copy link
Collaborator

@pritishnahar95 pritishnahar95 commented Sep 2, 2022

Description

Fixes # .

This change adds a Docker Plugin in Task Manager.
Docker Plugin will deploy MAPs as Docker Containers.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #398 (45c3431) into develop (01ae5e7) will increase coverage by 1.82990%.
The diff coverage is 88.37449%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #398         +/-   ##
===================================================
+ Coverage   57.12832%   58.95822%   +1.82989%     
===================================================
  Files            125         135         +10     
  Lines          15726       16683        +957     
  Branches        1672        1730         +58     
===================================================
+ Hits            8984        9836        +852     
- Misses          6463        6539         +76     
- Partials         279         308         +29     
Flag Coverage Δ
unittests 58.95822% <88.37449%> (+1.82989%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/TaskManager/API/Extensions/TypeExtensions.cs 66.66667% <0.00000%> (ø)
...ins/AideClinicalReview/AideClinicalReviewPlugin.cs 80.00000% <0.00000%> (+3.47826%) ⬆️
src/TaskManager/Plug-ins/Argo/ArgoPlugin.cs 88.21490% <ø> (ø)
src/TaskManager/Plug-ins/Argo/ArgoProvider.cs 81.25000% <ø> (ø)
...rc/TaskManager/Plug-ins/Argo/KubernetesProvider.cs 0.00000% <ø> (ø)
...nager/Plug-ins/Docker/ContainerMonitorException.cs 0.00000% <0.00000%> (ø)
...askManager/Plug-ins/Docker/IDockerClientFactory.cs 0.00000% <0.00000%> (ø)
...er/TaskManager/Extensions/TaskManagerExtensions.cs 0.00000% <0.00000%> (ø)
src/TaskManager/TaskManager/Program.cs 0.00000% <0.00000%> (ø)
src/WorkflowManager/Logging/Logging/Log.cs 25.00000% <0.00000%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ae5e7...45c3431. Read the comment docs.

@mocsharp mocsharp force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch from 187782b to 6a39992 Compare September 3, 2022 01:22
@mocsharp mocsharp changed the base branch from develop to health-endpoint September 3, 2022 01:22
@mocsharp mocsharp force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch from 6a39992 to e7be031 Compare September 3, 2022 01:24
@pritishnahar95 pritishnahar95 force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch 3 times, most recently from 5dea4cb to 45af57e Compare September 7, 2022 18:39
@mocsharp mocsharp force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch from 45af57e to 243f6f3 Compare September 8, 2022 20:22
@mocsharp mocsharp changed the base branch from health-endpoint to develop September 8, 2022 20:23
@mocsharp mocsharp force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch from 243f6f3 to be0dbe5 Compare September 9, 2022 17:38
@mocsharp mocsharp requested review from jackschofield23, JJFinnerty and neildsouth and removed request for JJFinnerty September 10, 2022 03:09
@mocsharp mocsharp force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch from 8967d14 to df8367f Compare September 12, 2022 15:12
pritishnahar and others added 9 commits September 12, 2022 08:13
Signed-off-by: pnahar <pnahar@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: pnahar <pnahar@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp force-pushed the pnahar/task-manager/docker-plugin/handle-task-event branch from df8367f to a70f01a Compare September 12, 2022 15:28
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

80.2% 80.2% Coverage
0.0% 0.0% Duplication

@mocsharp mocsharp merged commit 4d9558a into develop Sep 12, 2022
@mocsharp mocsharp deleted the pnahar/task-manager/docker-plugin/handle-task-event branch September 12, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants