Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deleted workflows triggering #406

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

jackschofield23
Copy link
Contributor

@jackschofield23 jackschofield23 commented Sep 6, 2022

Description

Fixes #402 .
Fixes deleted workflows triggering

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.

@jackschofield23 jackschofield23 force-pushed the fix-deleted-workflow-trigger branch 2 times, most recently from 353f5aa to 4d525c9 Compare September 6, 2022 14:25
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #406 (284a6e7) into develop (2a6110b) will decrease coverage by 0.06994%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #406         +/-   ##
===================================================
- Coverage   57.11560%   57.04566%   -0.06995%     
===================================================
  Files            125         125                 
  Lines          15726       15726                 
  Branches        1672        1672                 
===================================================
- Hits            8982        8971         -11     
- Misses          6465        6478         +13     
+ Partials         279         277          -2     
Flag Coverage Δ
unittests 57.04566% <0.00000%> (-0.06995%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...anager/Database/Repositories/WorkflowRepository.cs 0.00000% <0.00000%> (ø)
src/TaskManager/API/MetadataRepositoryBase.cs 11.11111% <0.00000%> (-38.88890%) ⬇️
...ug-ins/Argo/Repositories/ArgoMetadataRepository.cs 69.76744% <0.00000%> (-9.30234%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a6110b...284a6e7. Read the comment docs.

Signed-off-by: Jack Schofield <jack.schofield@answerdigital.com>
@RemakingEden
Copy link
Member

RemakingEden commented Sep 8, 2022

Needs int tests before merging @jackschofield23. I will do this next

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@neildsouth neildsouth merged commit 9009148 into develop Sep 9, 2022
@jackschofield23 jackschofield23 deleted the fix-deleted-workflow-trigger branch September 9, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows which have been marked as deleted are still triggered
3 participants