Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contributing guideline w/ .NET analyzer rules #72

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Conversation

mocsharp
Copy link
Collaborator

  • Add CONTRIBUTING.md
  • Update .editorconfig file with .NET analyzer rules to enforce coding styles, naming conventions
  • Add CODE_OF_CONDUCT.md

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the build label Mar 29, 2022
@mocsharp mocsharp self-assigned this Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #72 (73390f3) into main (33274f4) will decrease coverage by 0.76628%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #72         +/-   ##
===================================================
- Coverage   89.27203%   88.50575%   -0.76628%     
===================================================
  Files             22          22                 
  Lines            522         522                 
  Branches          20          20                 
===================================================
- Hits             466         462          -4     
- Misses            52          55          +3     
- Partials           4           5          +1     
Flag Coverage Δ
unittests 88.50575% <ø> (-0.76628%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adManager/Test/Services/Http/PayloadServiceTest.cs 76.92308% <0.00000%> (-10.25642%) ⬇️
...vices/JobSchedulingService/JobSchedulingService.cs 92.59259% <0.00000%> (-7.40741%) ⬇️
...ionDiscoveryService/ApplicationDiscoveryService.cs 92.59259% <0.00000%> (-7.40741%) ⬇️
...vices/DataDiscoveryService/DataDiscoveryService.cs 100.00000% <0.00000%> (+7.40740%) ⬆️
...vices/DataRetentionService/DataRetentionService.cs 100.00000% <0.00000%> (+7.40740%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33274f4...73390f3. Read the comment docs.

CONTRIBUTING.md Outdated Show resolved Hide resolved
- Update Dockerfile to use .NET6  images

Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mocsharp
Copy link
Collaborator Author

@joshliberty and team, please feel free to modify the rules if needed.

@mocsharp mocsharp merged commit 83422ed into main Mar 30, 2022
@mocsharp mocsharp deleted the vchang/dev-env branch March 30, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants