Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

Plug into Shared Memory #35

Closed
DennisOSRM opened this issue Jan 22, 2014 · 3 comments
Closed

Plug into Shared Memory #35

DennisOSRM opened this issue Jan 22, 2014 · 3 comments

Comments

@DennisOSRM
Copy link
Contributor

Node-osrm should use the shared memory facility of OSRM. From my point of view it is fair to also deprecate the ini files in the node bindings.

@springmeyer how much work do you think this is?

@springmeyer
Copy link

Currently in node-osrm shared_memory is available as an option, default off: https://github.com/DennisOSRM/node-osrm/blob/e903d5d749fe72a9df024199aecf4a78aae28e6b/src/options.hpp#L72-L79. I did this so that the tests could test both with and without shared memory: https://github.com/DennisOSRM/node-osrm/blob/e903d5d749fe72a9df024199aecf4a78aae28e6b/test/osrm.test.js#L74

But I gather you are thinking we should not expose this as an option and rather always use shared memory? I'm fine with that. Removing the option is a very easy change. Let me know if you'd like me to jump on that.

Removing ini usage is tracked at #29

@DennisOSRM
Copy link
Contributor Author

@springmeyer let's do shared memory by default. This will allow us to achieve less latency while likewise getting rid of http error messages from OSRMs own http module.

cc: @willwhite

@jfirebaugh
Copy link
Member

0d3679f, #55.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants