-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
Please accept this pull request if it finally fixes #279 |
There currently appear to be some issues with |
Can you check if it builds with |
@cordovapolymer It builds just fine for me (without a |
@jhermsmeier answered you in #279, as for a global build, I wouldn't mind if it could build and install locally, although it's not a big issue for my setup. When I just run |
It won't use your preinstalled This pull request is about making |
It won't use your preinstalled osrm-backend by default (and adding -g won't do that either), see https://github.com/Project-OSRM/node-osrm#using-an-existing-local-osrm-backend. Also, keep in mind that you'll have to have the same version of osrm-backend installed as the module specifies (in this case v5.5.4).
|
We merged node-osrm into the osrm-backend repo. - I updated node-cmake to v2 in doing so. Can you check if the node-osrm integration in osrm-backend works for you? It's still in its early staged, here are some prs and issues tagged nodejs: |
Fixes #279 – Installing via npm fails to build from source
Changes
NodeJS.cmake
generated byncmake update
,as
find_package
support has been removed (see node-cmake#removed-features).node
binding fromnode-osrm
tonode_osrm
due to it being used for namespace generation, resulting in build errors as it contained a dash