Skip to content
This repository has been archived by the owner on Jun 8, 2024. It is now read-only.

Update node-cmake to v2.x.x #280

Closed
wants to merge 1 commit into from
Closed

Update node-cmake to v2.x.x #280

wants to merge 1 commit into from

Conversation

jhermsmeier
Copy link

@jhermsmeier jhermsmeier commented Dec 23, 2016

Fixes #279 – Installing via npm fails to build from source

Changes

  • Added NodeJS.cmake generated by ncmake update,
    as find_package support has been removed (see node-cmake#removed-features)
  • Renamed the .node binding from node-osrm to node_osrm due to it being used for namespace generation, resulting in build errors as it contained a dash

@cordovapolymer
Copy link

Please accept this pull request if it finally fixes #279

@jhermsmeier
Copy link
Author

There currently appear to be some issues with node-cmake on Travis CI under Linux – I'm looking into ironing that out, but the Mac OS builds seem to be fine.

@cordovapolymer
Copy link

Can you check if it builds with sudo npm install --build-from-source -g --unsafe-perm on your machine?

@jhermsmeier
Copy link
Author

@cordovapolymer It builds just fine for me (without a --global install) – also, why are you trying to install it globally? If you don't mind, could you try and see what happens if you just run npm install for this one – does that build?

@cordovapolymer
Copy link

@jhermsmeier answered you in #279, as for a global build, I wouldn't mind if it could build and install locally, although it's not a big issue for my setup. When I just run npm install it builds both node-osrm and osrm-backend, but I want node-osrm to be build with my existing osrm-backend.

@jhermsmeier
Copy link
Author

When I just run npm install it builds both node-osrm and osrm-backend, but I want node-osrm to be build with my existing osrm-backend.

It won't use your preinstalled osrm-backend by default (and adding -g won't do that either), see https://github.com/Project-OSRM/node-osrm#using-an-existing-local-osrm-backend. Also, keep in mind that you'll have to have the same version of osrm-backend installed as the module specifies (in this case v5.5.4).

This pull request is about making node-osrm work under node v7+ (or other versions without pre-built osrm-backend binaries available) when installed as a dependency.

@cordovapolymer
Copy link

It won't use your preinstalled osrm-backend by default (and adding -g won't do that either), see https://github.com/Project-OSRM/node-osrm#using-an-existing-local-osrm-backend. Also, keep in mind that you'll have to have the same version of osrm-backend installed as the module specifies (in this case v5.5.4).
It doesn't build with lastest OSRM as well..

This pull request is about making node-osrm work under node v7+ (or other versions without pre-built osrm-backend binaries available) when installed as a dependency.
At a first look I thought it would solve my issue as well, I'll have to wait for another fix or get info how to fix it myself.

@daniel-j-h
Copy link
Member

We merged node-osrm into the osrm-backend repo. - I updated node-cmake to v2 in doing so.

Can you check if the node-osrm integration in osrm-backend works for you? It's still in its early staged, here are some prs and issues tagged nodejs:

@jhermsmeier jhermsmeier deleted the cmake-update branch April 21, 2017 16:23
@jhermsmeier jhermsmeier restored the cmake-update branch April 21, 2017 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants