This repository has been archived by the owner on Jun 8, 2024. It is now read-only.
Added support for 'nearest' and 'locate' queries #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,9 @@ | |||
| #include <node_version.h> | |||
| #include <node_object_wrap.h> | |||
|
|
|||
| // stl | |||
| #include <string.h> | |||
There was a problem hiding this comment.
Should just be #include <string>. The .h works, but is the C header, convention is to use the c++ header.
|
Great job. I made a few minor comments inline that would be good to fix, then i'll merge. Thanks! |
|
Pull request updated--thanks for the quick review and feedback @springmeyer! (C++ noob here...) |
|
tests passed (https://travis-ci.org/DennisOSRM/node-osrm/builds/20963738). nice work, merging. |
springmeyer
pushed a commit
that referenced
this pull request
Mar 18, 2014
Added support for 'nearest' and 'locate' queries
|
Awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #52 and #44.
You might make an argument for having a
Querybase class withRoutingQuery,NearestQuery, andLocateQuerysub-classes, but this just seems like overkill... Opted for a simple addition of a "if this is a 'nearest' or 'locate' query" conditional block to the existingQueryclass.Hoping we can move forward with this for now.