New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding restrictions at traffic islands for correct routing #2611
Comments
The problem here isn't a missing turn restriction, it's the differences in road speeds leading to a bad calculation inside OSRM. Here are the timings for each segment that OSRM has internally: From A->B, there are two choices: via the slip-road, it'll take 6.1s. Via the main road, it'll take 6.0s. There should be a turn penalty value where I've got It's probably just a matter of very tiny differences in time (e.g. 0.1s in this case). OSRM is pretty brutal about that -> the fastest is the fastest. Thanks for highlighting the bad routing here. Do not add turn restrictions to fix this if they're not valid on the ground - we need to adjust the turn penalties and road speeds in OSRM for this to work properly. |
Well it is not quite that simple. Looking at the lane indications in the above picture they explicitly state that are are supposed to turn left. That means they imply a only-left restriction. I think it is completely valid to tag them in this case. Road markings are just one way of indicating turn restrictions. |
Fully agree on that. I even use lane markings partly already to disable some turns during the graph generation. |
Here's another example https://www.openstreetmap.org/relation/5771246@MoKob are the road intersections angles used in anyway to penalize such a turn or is a restriction necessary?
Is this something that could be used to propose some revised mapping conventions, like `avoid adding turn restrictions unnecessary if the turn lane tags can indicate what turns are restricted at the junction'? |
@planemad Turn angles can be penalised in the profiles via a turn_function. The penalisation should not influence whether a turn is allowed or not. If the turn is not allowed, it should be in the data. It could always be that a different route would require a significant detour, resulting in the turn still being used. The same can be said for:
While I try and get the maximum out of the data, heuristics should not be a reason to exclude valid mappings. If a turn is not allowed, the data should reflect so. |
The conclusion here is that restrictions based on lane markings seem like a reasonable thing to do, and OSRM already supports that. Nothing actionable on the OSRM side here, closing. |
There are numerous instances of restrictions on OSM at junctions with free turns and traffic islands like this for correct routing.
A no right restriction added at a junction with a separate free right turn
_Satellite image showing left turn lanes on the same road to the junction_
The issue here is:
No Right
traffic sign, that can be used to verify the restriction, and goes against the recommended practice of mapping what is visible. What is a consistent approach to mapping such restrictions?cc @Andygol @maning
The text was updated successfully, but these errors were encountered: