Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Turn Lane Matcher #3127

Open
MoKob opened this issue Oct 20, 2016 · 0 comments
Open

Refactor Turn Lane Matcher #3127

MoKob opened this issue Oct 20, 2016 · 0 comments

Comments

@MoKob
Copy link

MoKob commented Oct 20, 2016

Turn lane matching operates on a straight forward approach: the best fit for a turn lane should we were we use it.
E.g. a through should be on the most obvious turn.

We should reconsider these settings which are defined in the turn-lane-matcher (here).

Especially the validity of a map is currently very ugly (see here).

The current setting assumes that the rightmost turn is also the rightmost turn-lane.
This is not necessarily true, as through|left is a valid combination where a turn lane is on the right to turn left.

I imagine we could move to a two-tier system. In most cases, it should be fine to do an assignment from right through to left (only considering valid turns), checking if modifiers and turn-directions match up.

This depends on a good handling in #3126.

In a second set of items, we can later add scenarios that allow other matches as well. I believe that these should be the minority of settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Refactor Guidance
Preprocessing/Extraction
Development

No branches or pull requests

1 participant