Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geometry math in coordinate extraction should have test coverage #3398

Open
danpat opened this issue Dec 2, 2016 · 0 comments
Open

Geometry math in coordinate extraction should have test coverage #3398

danpat opened this issue Dec 2, 2016 · 0 comments
Labels
Guidance Refactor

Comments

@danpat
Copy link
Member

danpat commented Dec 2, 2016

The fix made in #3397 highlighted that we're missing test coverage for some core math inside the coordinate extractor.

Many of the private methods in CoordinateExtractor have clean signatures, no side-effects and perform some moderately complex logic - we should refactor them into a place where they can have tests added.

/cc @MoKob
@danpat danpat added this to the 5.6.0 milestone Dec 2, 2016
@TheMarex TheMarex modified the milestones: 5.7.0, 5.6.0 Jan 28, 2017
@TheMarex TheMarex removed this from the 5.7.0 milestone Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Guidance Refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheMarex @danpat