Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need new home for publishing binary modules #6013

Closed
danpat opened this issue Apr 16, 2021 · 3 comments · Fixed by #6030
Closed

Need new home for publishing binary modules #6013

danpat opened this issue Apr 16, 2021 · 3 comments · Fixed by #6030

Comments

@danpat
Copy link
Member

danpat commented Apr 16, 2021

#6012 removes the AWS access keys for publishing to the Mapbox S3 mapbox-node-binaries bucket. Old binaries are still available, but TravisCI will no longer be able to push new ones there.

The reason for this token revocation is https://about.codecov.io/security-update/

We should update our build scripts to push somewhere new - possibly to GitHub Packages?

New releases with published binaries will be blocked until this is fixed somehow.

@mjjbell
Copy link
Member

mjjbell commented Apr 22, 2021

It looks like node-pre-gyp only supports publishing to S3: https://github.com/mapbox/node-pre-gyp#host
If there isn't alternative S3 hosting available, we could investigate creating a module for publishing to Github Packages similar to https://github.com/bchr02/node-pre-gyp-github

@akashihi
Copy link
Contributor

I can talk back to Wolt and try to organize S3 hosting there

@mjjbell
Copy link
Member

mjjbell commented May 8, 2021

If there isn't alternative S3 hosting available, we could investigate creating a module for publishing to Github Packages similar to https://github.com/bchr02/node-pre-gyp-github

On further investigation, Github Packages only provides a replacement for the registry component, and doesn't offer anything that would replace S3 for the platform-dependent binary hosting.

I've made #6030 that uses Github Releases for hosting. Inspired by this comment, rather than use the plugin mentioned above, it's possible to integrate it into the existing node-pre-gyp usage and Travis builds with minimal changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants