Fix formatToken() callback to process only non-empty tokens #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yuryleb
force-pushed
the
formatToken-fix
branch
from
cb7661a
to
786b928
Compare
|
And additionally don't highlight prepending articles/prepositions from French names added by recently proposed French grammar rules: |
|
Very nice display, this way! |
|
Rebased. |
And also to don't handle 'name' tokens so it's called before final instruction text formatting and grammar rules applying
|
Rebased more once for convenient merge. @danpat, actually this is more important PR than recently merged ones - it allows to properly work both Russian and French grammars 😉 |
|
Tada! |
|
Thank you for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also to don't handle 'name' tokens so it's called before final instruction text formatting and grammar rules applying.
Please look at route steps before this fix:
And after (grammar rules restored; no name roads kept original):