Grammar notes update for Swift implementation #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuryleb
force-pushed
the
grammar-notes-update
branch
2 times, most recently
from
a0b7a76
to
05290ed
Compare
|
@1ec5 can you take a look at this? |
yuryleb
force-pushed
the
grammar-notes-update
branch
3 times, most recently
from
bdb7efa
to
f1a5114
Compare
yuryleb
force-pushed
the
grammar-notes-update
branch
from
f1a5114
to
30816aa
Compare
1ec5
approved these changes
Nov 3, 2017
| @@ -28,9 +28,21 @@ The required grammatical case should be specified right in instruction's substit | |||
| - Instruction text formatter ([index.js](index.js) in this module) should: | |||
| - check `{way_name}` and `{rotary_name}` variables for optional grammar case after colon: `{way_name:accusative}` | |||
| - find appropriate regular expressions block for target language and specified grammar case | |||
| - call standard [string replace with regular expression](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace) for each expression in block passing result from previous call to the next; the first call should enclose original street name with whitespaces to make parsing words in names a bit simplier. | |||
| - call standard [string replace with regular expression](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace) for each expression in block passing result from previous call to the next; the first call should enclose original street name with whitespaces to make parsing several words inside name a bit simplier. | |||
There was a problem hiding this comment.
Is this still a requirement, now that grammarize is called before capitalization and insertion (#170)?
|
@1ec5 Yes, the changes to the grammar rules look good to me. |
|
Thanks @yuryleb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Grammar feature description with notes about OSRM Text Instructions for Swift implementation specifics - always global matching regardless of specified regular expressions flags.
Some Russian regular expressions are also joint and optimized to work better in Swift too.