Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add created_at to dataset and Campaign #131

Merged
merged 6 commits into from
Nov 20, 2023
Merged

add created_at to dataset and Campaign #131

merged 6 commits into from
Nov 20, 2023

Conversation

Qouagga
Copy link
Contributor

@Qouagga Qouagga commented Oct 31, 2023 •
edited
Loading

#80

@Qouagga Qouagga requested a review from ixio October 31, 2023 16:17
@Qouagga Qouagga changed the title ordering dataset and Campaign add created_at to dataset and Campaign Nov 8, 2023
@rvovard rvovard self-requested a review November 8, 2023 15:01
rvovard
rvovard previously requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@rvovard rvovard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front code is OK, but it seems that something's wrong with the backend migrations.

backend/api/migrations/0023_auto_20231020_1755.py Outdated Show resolved Hide resolved
@rvovard rvovard mentioned this pull request Nov 8, 2023
Merged
7 tasks
@Qouagga Qouagga force-pushed the feature/campaign-date-created branch 3 times, most recently from 6c6f19e to 402f489 Compare November 10, 2023 17:00
ixio
ixio reviewed Nov 13, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@Qouagga Qouagga force-pushed the feature/campaign-date-created branch from 5a8fae3 to 554e151 Compare November 17, 2023 10:19
@Qouagga Qouagga force-pushed the feature/campaign-date-created branch from 554e151 to a8b47ab Compare November 20, 2023 13:31
ixio
ixio approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ixio ixio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Qouagga Qouagga merged commit f1bac2f into master Nov 20, 2023
2 checks passed
@Qouagga Qouagga deleted the feature/campaign-date-created branch November 20, 2023 13:39
@ixio ixio mentioned this pull request Nov 24, 2023
Merged
@ElodieENSTA ElodieENSTA linked an issue Dec 12, 2023 that may be closed by this pull request
Order Annotation campaigns and datasets on APLOSE #80
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ixio ixio ixio approved these changes

@rvovard rvovard rvovard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order Annotation campaigns and datasets on APLOSE
3 participants
@Qouagga @ixio @rvovard