Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duck Commands base + Wifi on/off for frontend. Serial_writer implementation of duck commands. #12

Merged
merged 7 commits into from
Sep 17, 2022

Conversation

Teikahym
Copy link
Contributor

@Teikahym Teikahym commented Jul 24, 2022

Describe at a high level the solution you're providing A clear and concise description of what you changed.

  • Adds frontend functionality for Duck Commands by creating a new clusterCommands SQL-table.
  • Implements the WiFi on and off commands for each duck on the ducks page.
  • passes commands to PaPi (serial only)
  • fixes tablefilter include

Is this a patch, a minor version change, or a major version change Patch, minor, or major.
minor change

Is this related to an open issue? Please provide the link.
#10

Additional context Add any other technical detail or considerations here.
Frontend inserts a new row into the clusterCommands table for each command.
SQL_writer checks tries to pull one command each second and passes it on to PaPi (via serial JSON for serial_writer).
Currently only WiFi on/off for individual ducks is implemented fully.

Signed-off-by: Teikahym <sebifri@gmail.com>
@hawk4031
Copy link
Member

@Teikahym Can you merge the main branch over into yours here and make sure everything is still good? A couple changes I would make based on the new changes in main will be to find the spots where we hardcoded mariadb as the database host and replace it with os.getenv('MYSQL_HOST') (you will see it in the changes from the main branch in a few places).

Everything else looks good to me. Make that change and then we can get this PR approved!

@Teikahym
Copy link
Contributor Author

@hawk4031 Adapted the code and fixed the include for tablefilter.

@TimoWielink
Copy link
Member

@hawk4031 Looks good to me!

@hawk4031 hawk4031 merged commit 588306c into Project-Owl:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants