Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 3.20.1 export issues from #102 #104

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

zao
Copy link
Collaborator

@zao zao commented Jan 13, 2023

Abstract

Addresses some problems reported in #102 on legacy region watchstones, cosmetic type and theme.

Action Taken

All legacy watchstones are now skipped by list of IDs.
Cosmetic type and theme has been moved to CurrencyItems and ShopTag, code updated to track the new data.

Caveats

Quest rewards not addressed yet, PR is WIP.
Not sure if there's a more elegant way to skip the legacy watchstones en masse or a way to restore the old class name and keep them exportable.

FAO

@acbeaumo

@acbeaumo
Copy link
Collaborator

Caveat:

Alternate skill effects used to all be typed as "Skill Gem Effect". Now the value of the CosmeticTypeName field in CurrencyItems is different based on what gems it applies to. Ex1) Spirit Blink and Mirror Arrow Effect has the value "Blink and Mirror Arrow Skin". Ex2) Force Field Aura Effect has the value "Aura Skin".

The wiki's item template will need to be updated so that it doesn't error and to ensure that cosmetic items are categorized correctly.

The data files for quest rewards have returned a few leagues ago, this
restores the old quest reward exporter with adaptations to the spec.

There's a new field which seems to indicate if a reward is for any
difficulty or specific to normal or hard mode (Ruthless).

Some of the past workarounds w.r.t item names might be possible to
remove but it's kept close to the original form for now.

Note that this does not include quest _vendor_ rewards, those seem to be
gone for good.
@zao
Copy link
Collaborator Author

zao commented Jan 18, 2023

Quest rewards reintroduced by lifting the old export code for them and adapting it for DAT64 and changes in specs. There's a bunch of old hacks that may not be needed anymore.

I'm not certain how we want to handle rewards that involve Hard mode (Ruthless). I've tagged rewards with a difficulty field of any, normal, hard but don't know how that would affect consuming code on the wiki.

Exports currently look like this, haven't compared with past state: quest_rewards.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants