Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor_styles not compatible with WordPress 4.1 #21

Closed
webstylr opened this issue Dec 28, 2014 · 4 comments
Closed

editor_styles not compatible with WordPress 4.1 #21

webstylr opened this issue Dec 28, 2014 · 4 comments
Labels

Comments

@webstylr
Copy link

When using Semantic-UI-WordPress with WordPress 4.1, strange things happen to the Editor/TinyMCE.
To illustrate the behavior, please see the attached screenshots.

As long as add_editor_style('assets/styles/semantic.min.css'); is enabled, the Editor behaves in strange ways.
For example, for every mouseclick you trigger inside the Editor, a linebreak witll be inserted.
The same goes for entering content. For every character you insert, a linebreak will be added below the text.

It looks like passing the semantic.css to tinymce causes some trouble with how tinymce constructs the editor.
bildschirmfoto 2014-12-28 um 13 09 08
bildschirmfoto 2014-12-28 um 13 09 50

@ProjectCleverWeb
Copy link
Owner

Investigating this... could you please be more specific, I am not entirely sure I know what you are trying to point out.

@ProjectCleverWeb
Copy link
Owner

@webstylr I figured out what you were talking about. The editor isn't adding line breaks, it is incorrectly adjusting the height onClick. (this is what would normally prevent scroll bars from appearing when the content of the editor is larger than the default editing area.

At the moment, I am having trouble locating what exactly is causing this miscalculation, but I report back here when it is fixed.

@webstylr
Copy link
Author

webstylr commented Jan 3, 2015

@ProjectCleverWeb sorry for being quiet for a few days, was on a short vacation ;)
While investigating this bug i found that if semtantic is loaded the html-strucure of the document is different compared to the html constructed without semtantic injected into tinymce.

HTML without semantic https://gist.github.com/webstylr/92c39a08f952984c03b9
HTML with semantic https://gist.github.com/webstylr/0afc1f6640cbc269a8cb

If there is anything i could do to help, please let me know.

@ProjectCleverWeb
Copy link
Owner

@webstylr Got this fixed, thanks for your help with finding this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants