MaxListenersExceededWarning: Possible EventEmitter memory leak detected

[thescientist13]

Type of Change

• New Feature Request
• Documentation / Website
• Improvement / Suggestion
• Bug
• Other (please clarify below)

Summary

As part of working on #122 this warning started showing

(node:46265) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 exit listeners added. Use emitter.setMaxListeners() to increase limit
(node:46265) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGINT listeners added. Use emitter.setMaxListeners() to increase limit
(node:46265) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGTERM listeners added. Use emitter.setMaxListeners() to increase limit
(node:46265) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGHUP listeners added. Use emitter.setMaxListeners() to increase limit

Details

Some initial Googling suggested that it could be related to us not closing browser?
puppeteer/puppeteer#594

One quick option is to set process.setMaxListeners(0);

[thescientist13]

Given our proposal in #16 , then it might make sense to approach this using the "quick" solution of setting process.setMaxListeners(0);

[thescientist13]

It is ugly looking output though. :/

I suppose if we do go with the "quick" approach, then we should promote #16 for the next sprint so we don't run into unintended consequences for larger projects (if indeed the issue is not closing browser)