Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setMaxListeners suppression call #1046

Conversation

thescientist13
Copy link
Member

Related Issue

related to #141

As part of investigating a similar issue in #1045, noticed that we be able to remove this, as prophecised in this comment - #141 (comment)

Summary of Changes

  1. Removed setMaxListeners(0)

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI labels Jan 18, 2023
@thescientist13 thescientist13 added this to the 1.0 milestone Jan 18, 2023
@thescientist13 thescientist13 linked an issue Jan 18, 2023 that may be closed by this pull request
5 tasks
@thescientist13 thescientist13 force-pushed the enhancement/issue-141-revert-max-listeners-warning-suppression branch from 84033b7 to 4186d69 Compare January 19, 2023 02:40
@thescientist13 thescientist13 force-pushed the enhancement/issue-141-revert-max-listeners-warning-suppression branch from 4186d69 to a55fc2b Compare February 7, 2023 02:24
@thescientist13 thescientist13 force-pushed the enhancement/issue-141-revert-max-listeners-warning-suppression branch from a55fc2b to 4cf20ba Compare February 18, 2023 00:46
@thescientist13 thescientist13 merged commit 0e0f744 into release/0.28.0 Feb 18, 2023
@thescientist13 thescientist13 deleted the enhancement/issue-141-revert-max-listeners-warning-suppression branch February 18, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.2 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.28.0
Projects
Development

Successfully merging this pull request may close these issues.

MaxListenersExceededWarning: Possible EventEmitter memory leak detected
1 participant