Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<meta> Component package #304

Closed
1 of 5 tasks
thescientist13 opened this issue Mar 18, 2020 · 0 comments · Fixed by #417 or #892
Closed
1 of 5 tasks

<meta> Component package #304

thescientist13 opened this issue Mar 18, 2020 · 0 comments · Fixed by #417 or #892

Comments

@thescientist13
Copy link
Member

thescientist13 commented Mar 18, 2020

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Coming out of #303 it makes sense to expose a standalone "<meta>" component with a general purpose API that could be used a la react-helmet.

Details

Something like this, ideally opting for a declarative API as a custom element (see #299 for reference)

<meta .title="${title}" .meta="${meta}"/>
  • title would be a string for the page's <title>
  • meta would be an Array of <meta> tags

Interesting tweet for consideration

In addition, we can now tap into the graph as part of ResourceInterface which means we can get per page data, really really great for SEO. 🤩

Questions

How should we package this, as a standalone package to publish to NPM? If so, will it then need to be a dependency of @greenwood/cli?

Or maybe there's a plugin we could use to pull this in for users through a transitive dependency? Does that mean it's not default?

Could also have this all done via SSR as Resource with an interceptor?

@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Mar 18, 2020
@thescientist13 thescientist13 changed the title Meta Component <meta> Component Mar 18, 2020
@thescientist13 thescientist13 added the question Further information is requested label Mar 18, 2020
@thescientist13 thescientist13 changed the title <meta> Component <meta> Component package Mar 22, 2020
@thescientist13 thescientist13 moved this from IN REVIEW to TODO in 5 - Architectural Digest Nov 8, 2020
@thescientist13 thescientist13 moved this from TODO to PENDING in 5 - Architectural Digest Nov 12, 2020
@thescientist13 thescientist13 moved this from PENDING to DEFERRED in 5 - Architectural Digest Mar 18, 2021
@thescientist13 thescientist13 removed the question Further information is requested label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
No open projects
1 participant