restore default meta tags and update website #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
thescientist13
changed the title
5 tasks
|
So one good idea coming out of the discussion on this for us would be to make a Favicons plugin, that can take a path to a favicon.png or something like that, and spit out a bunch of favicon image formats, as well as adding all the needed |
53 tasks
…template-meta-tags
thescientist13
deleted the
bug/issue-446-missing-default-app-template-meta-tags
branch
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #446
Summary of Changes
<meta>tags to default app templateThoughts / Questions
I guess one thing this does present, is how would it look like for an application to edit more custom tags on a per page basis (like for a blog post's unique title, description, author,
og:*, etc)?I know in React / Gatsby land they use React Helmet so from any component you can dynamically update the
<head>after pulling data out of GraphQL. I suppose this would justify #304 and something we can introduce as a standalone library?Otherwise, it's just as easy to recommend / suggest using basic
documentmethods, but either way we should probably have a combination of one or more (or all) of these - example, doc, package. I can update #304 with some comments and put it into our next project board.