Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

top level HTML page builds without the page content (v0.10.0-alpha.1) #456

Closed
1 of 5 tasks
thescientist13 opened this issue Dec 24, 2020 · 1 comment · Fixed by #476
Closed
1 of 5 tasks

top level HTML page builds without the page content (v0.10.0-alpha.1) #456

thescientist13 opened this issue Dec 24, 2020 · 1 comment · Fixed by #476
Assignees
@thescientist13
Labels
alpha.7 bug Something isn't working CLI good first issue Good for newcomers P0 Critical issue that should get addressed ASAP v0.10.0
Projects
5 - Architectural Digest
Milestone
No Bundle Feature...

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Noticed that if there is a top level page, e.g.

src/
  pages/
    index.html
    test.html // <--- this file
<!DOCTYPE html>
<html lang="en" prefix="og:http://ogp.me/ns#">

  <body>
    <h1>Test!!!!!</h1>
  </body>

</html>

Doesn't display any content on the page. Routing and everything seems OK though, fwiw.
Screen Shot 2020-12-24 at 12 51 49 PM

Details

Tested in #449 which gets us close, but not all the way there. Should also see if #450 helps at all. Probably just a small thing in the transforms logic.
@thescientist13 thescientist13 added bug Something isn't working good first issue Good for newcomers CLI labels Dec 24, 2020
@thescientist13 thescientist13 self-assigned this Dec 24, 2020
@thescientist13 thescientist13 removed their assignment Dec 24, 2020
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Dec 25, 2020
@thescientist13 thescientist13 self-assigned this Dec 25, 2020
@thescientist13
Copy link
Member Author

thescientist13 commented Dec 25, 2020 •
edited
Loading

This is actually causing the Plugins -> index section to not show, probably related to index naming collision, so try and fix that too please. :)
b2be2da#diff-f7b32ce37b7894cd1e457db442f27944af5e799d7880860ed331c4bb89a479cbR162

@thescientist13 thescientist13 moved this from TODO to IN PROGRESS in 5 - Architectural Digest Feb 14, 2021
@thescientist13 thescientist13 mentioned this issue Feb 14, 2021
Merged
@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 5 - Architectural Digest Feb 14, 2021
@thescientist13 thescientist13 linked a pull request Feb 14, 2021 that will close this issue
Bug/issue 456 top level pages not building correctly #476
Merged
@thescientist13 thescientist13 mentioned this issue Feb 27, 2021
Merged
12 tasks
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 5 - Architectural Digest Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.7 bug Something isn't working CLI good first issue Good for newcomers P0 Critical issue that should get addressed ASAP v0.10.0
Projects
No open projects
5 - Architectural Digest
DONE
Milestone
No Bundle Feature Parity
Development

Successfully merging a pull request may close this issue.

Bug/issue 456 top level pages not building correctly ProjectEvergreen/greenwood
1 participant
@thescientist13