Bug/issue 386 graph not matching filesystem order #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
thescientist13
commented
Dec 18, 2020
| @@ -33,7 +33,7 @@ class HTMLTransform extends TransformInterface { | |||
| let body = await getAppTemplate(barePath, this.workspace); | |||
| body = await getAppTemplateScripts(body, this.workspace); | |||
| body = getUserScripts(body, this.workspace); | |||
| body = getMetaContent(url, this.config, body); | |||
| body = getMetaContent(url.replace('index.html', ''), this.config, body); | |||
There was a problem hiding this comment.
this was sending URLs w/ index.html in the url so this strips that to keep nice clean URLs, e.g.
www.example.com/about/index.html
is now
although this makes more sense to do in getMetaContent?
There was a problem hiding this comment.
edit x2: actually, looks like I don't need it there, the tests pass without it, so I must have fixed the issue that caused this. 😎
This was referenced Dec 19, 2020
This was
linked to
issues
Dec 25, 2020
5 tasks
thescientist13
force-pushed
the
bug/issue-386-graph-not-matching-filesystem-order
branch
from
b2be2da
to
70e9dc4
Compare
5 tasks
5 tasks
5 tasks
thescientist13
deleted the
bug/issue-386-graph-not-matching-filesystem-order
branch
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* init refactor with synchronous approach working * robust nested directory output testing * formatting * robust nested directory output testing * graph page object clean up * graph lifecycle refactor: * revert transform changes * fix #455 * fix routing logic * fix incorrect output when pages have index in the name
thescientist13
added a commit
that referenced
this pull request
Apr 3, 2021
* init refactor with synchronous approach working * robust nested directory output testing * formatting * robust nested directory output testing * graph page object clean up * graph lifecycle refactor: * revert transform changes * fix #455 * fix routing logic * fix incorrect output when pages have index in the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #386 (and incorporates #455 / #331 somewhat) , as I have noticed it is happening in my personal project still, and fairly consistently- thegreenhouseio/www.thegreenhouse.io#174 (comment)
Summary of Changes
walkDirectorylogic synchronous, which makes this issue go away at least (async programming is hard 😞 )routeis normalized and "safe" to use and always end with/, solves routes with and without trailing forward slash causes route "misses" #331Nice To Have
walkDirectoryto not rely oncontext, so it can move out of the scope ofmodule.exportsedit: tracking both of the above in Trello for post 1.0 efforts / optimizations