Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable stylelint rule for reduced motion blur for home page banner button #510

Closed
1 of 5 tasks
thescientist13 opened this issue Apr 4, 2021 · 0 comments · Fixed by #757
Closed
1 of 5 tasks

enable stylelint rule for reduced motion blur for home page banner button #510

thescientist13 opened this issue Apr 4, 2021 · 0 comments · Fixed by #757
Assignees
Labels
chore unit testing, maintenance, etc good first issue Good for newcomers website Tasks related to the projects website / documentation

Comments

@thescientist13
Copy link
Member

thescientist13 commented Apr 4, 2021

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

When adding stylelint recently and in the process of merging #436 (v0.10.0) I wasn't able to resolve this a11y rule for the home page banner component button.

Screen Shot 2021-04-04 at 7 21 31 PM

Details

Basically need to be able to uncomment this disable line

/* stylelint-disable a11y/media-prefers-reduced-motion */
:host .btn {
  display: inline-block;
  border-radius: 10px;
  font-size: 1.2rem;
  padding: 0.75rem;
  color: white;
  background-color: #201e2e;
  border: 1px solid white;
  transition: 0.3s;
}

:host .btn:hover,
:host .btn:focus {
  background-color: #425d58;
  border: 1px solid white;
}

and correctly apply the @media rule like seen in banner.css

@media screen and (prefers-reduced-motion: reduce) {
  & span.off {
    animation: none;

    @media (prefers-reduced-motion) {
      animation: 0;
    }
  }
}

_Bonus points: if you like this one, we can also try adding an eslint-lit-a11y plugin as well

@thescientist13 thescientist13 added good first issue Good for newcomers chore unit testing, maintenance, etc website Tasks related to the projects website / documentation labels Apr 4, 2021
@thescientist13 thescientist13 changed the title enable stylelint rule for reduced motion blur for home page button enable stylelint rule for reduced motion blur for home page banner button Apr 4, 2021
@aholtzman aholtzman self-assigned this Oct 9, 2021
@thescientist13 thescientist13 linked a pull request Oct 13, 2021 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore unit testing, maintenance, etc good first issue Good for newcomers website Tasks related to the projects website / documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants