Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep init command in sync with latest stable Greenwood CLI version when scaffolding package.json #781

Closed
1 of 5 tasks
thescientist13 opened this issue Oct 29, 2021 · 1 comment · Fixed by #815 or #816
Closed
1 of 5 tasks
Assignees
Labels
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Currently as part of #778 and related to #770 , we are using a hardcoded package.json to use as the template for scaffolding. This means the version of the @greenwood/cli in the generated package.json will never bump unless we change it ourselves. It would be good to find a mechanism to try and keep this up to date as part of each new release.

Details

Basically, the init package should pull from its own package.json each time and use that as the installed version. The only question is, if it's an alpha.x release though, e.g. ^0.19.0-alpha.1 we should probably fallback to last minor, e.g. ^0.18.0.

@thescientist13 thescientist13 added chore unit testing, maintenance, etc Init labels Oct 29, 2021
@thescientist13 thescientist13 added this to the 1.0 milestone Oct 29, 2021
@thescientist13 thescientist13 changed the title keep version of greenwood/cli version output as part of init in sync with latest stable CLI version keep greenwood/cli version in sync with latest stable CLI version when running init command Oct 29, 2021
@thescientist13

This comment has been minimized.

@thescientist13 thescientist13 changed the title keep greenwood/cli version in sync with latest stable CLI version when running init command keep init command in sync with latest stable Greenwood CLI version when scaffolding _package.json_ Nov 29, 2021
@thescientist13 thescientist13 changed the title keep init command in sync with latest stable Greenwood CLI version when scaffolding _package.json_ keep init command in sync with latest stable Greenwood CLI version when scaffolding package.json Nov 29, 2021
@thescientist13 thescientist13 added feature New feature or request and removed chore unit testing, maintenance, etc labels Nov 29, 2021
@thescientist13 thescientist13 self-assigned this Dec 6, 2021
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 7 - SSR and External Data Sources Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1 participant