Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have init lock step initial version to current Greenwood version #816

Merged
merged 4 commits into from
Dec 9, 2021
Merged

have init lock step initial version to current Greenwood version #816

merged 4 commits into from
Dec 9, 2021

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 6, 2021 •
edited

Related Issue

resolves #781 (and indirectly invalidates / resolves #809 )

Summary of Changes

  1. Lock step the initial version of Greenwood to whatever the current version is (this will ensure proper installation of new projects so they don't start on an old and broken version of Greenwood, as far as the ESM upgrade goes 😨 )
  2. As a formality, bumped the minimum version in template/package.json

Not sure why #809 doesn't work as expected, but haven't put any time looking into it, since solving this issue was easy enough. But would still like to know why. 🧐

@thescientist13 thescientist13 added feature New feature or request Init labels Dec 6, 2021
This was linked to issues Dec 6, 2021
keep init command in sync with latest stable Greenwood CLI version when scaffolding package.json #781
Closed
init command is not self upgrading to latest (sem) version of Greenwood #809
Closed
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 6, 2021
@thescientist13 thescientist13 removed this from the 1.0 milestone Dec 6, 2021
@thescientist13 thescientist13 mentioned this pull request Dec 6, 2021
Merged
20 tasks
@thescientist13 thescientist13 merged commit bfb2e3d into release/0.20.0 Dec 9, 2021
@thescientist13 thescientist13 deleted the feature/issue-781-lockstep-init-default-greenwood-version branch December 9, 2021 16:06
thescientist13 added a commit that referenced this pull request Dec 9, 2021
@thescientist13
have init lock step initial version to current Greenwood version (#816)
0ee47ad 
* have init lock step initial version to current Greenwood version

* set minimum version as formality in template package.json

* grammar
thescientist13 added a commit that referenced this pull request Dec 18, 2021
@thescientist13
have init lock step initial version to current Greenwood version (#816)
9055885 
* have init lock step initial version to current Greenwood version

* set minimum version as formality in template package.json

* grammar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hutchgrant hutchgrant Awaiting requested review from hutchgrant

Assignees
No one assigned
Labels
feature New feature or request Init
Projects
None yet
Milestone
No milestone
1 participant
@thescientist13