Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills plugin should feature detect polyfills support (using webcomponents loader) #9

Closed
1 of 5 tasks
thescientist13 opened this issue Mar 27, 2019 · 3 comments
Closed
1 of 5 tasks
Assignees
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.4.0 Plugins and Packages
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Mar 27, 2019

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Currently, polyfills are enabled by default. I think for a static site, as few dependencies should be needed, but if some are needed to support browsers, they should be opt-in, ideally through differential loading

Edit: we won't be implementing differential loading, instead we are using our evergreen build.

Details

  1. Disable polyfills by default (this may not be possible right away, or may require coordinate work, see decouple polyfills for serialization from polyfills needed for users #193 )
  2. Allow opt-in flag specifically for IE11 (es5 adapter?)
  3. Support custom .browserslistrc (nice to have - new ticket?)
  4. Write test cases for these use cases
  5. Update README with documentation / samples of the above use cases
  6. Looks like we'll need to migrate PostCSS
  7. Use webcomponent-loader or everything? (but actually is bigger bundle size wise than just using bundle?)
  8. Question: confirm which browsers actually need polyfills
@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Mar 27, 2019
@thescientist13 thescientist13 removed this from the Project Website milestone Jul 4, 2019
@thescientist13
Copy link
Member Author

Maybe it would be better to turn this into an RFC, more thoughts come to mind

@thescientist13 thescientist13 added RFC Proposal and changes to workflows, architecture, APIs, etc and removed enhancement Improve something existing (e.g. no docs, new APIs, etc) labels Jul 27, 2019
@thescientist13 thescientist13 changed the title As a user I should be able to configure polyfills for older browsers (define browser support) [RFC] Differential Loading Jul 27, 2019
@thescientist13 thescientist13 added this to the MVP milestone Jul 27, 2019
@thescientist13
Copy link
Member Author

Looks like our Lighthouse Performance score could improve as part of this if there's a better way to handle loading of polyfills
Screen Shot 2019-08-13 at 9 32 34 PM

@thescientist13
Copy link
Member Author

There are about three items that are left, not really related to what true differential loading is though which is basically generating two bundles, but with preset-env we're mainly leaning towards an intelligently generated common bundle.

  1. Allow opt-in flag specifically for IE11 (es5 adapter?)
  2. Support custom .browserslistrc (nice to have - new ticket?)
  3. Use webcomponent-loader or everything? (but actually is bigger bundle size wise than just using bundle?)

The bulk of the heavy lifting coming from polyfills though instead of the straight bundle, we should switch to using the loader, so that it can feature detect the right polyfills to load without the cost of the whole bundle.

The rest of the open items could probably be made their own (single) issue.

@thescientist13 thescientist13 moved this from IN PROGRESS to IN REVIEW in 3 - Plugins and Packages (0.4.0) Sep 27, 2019
@thescientist13 thescientist13 changed the title [RFC] Differential Loading Polyfills plugin should feature detect polyfills support (using webcomponents loader) Sep 27, 2019
@thescientist13 thescientist13 added v0.4.0 Plugins and Packages enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins and removed Plugins Greenwood Plugins RFC Proposal and changes to workflows, architecture, APIs, etc labels Oct 16, 2019
@thescientist13 thescientist13 moved this from IN REVIEW to DONE in 3 - Plugins and Packages (0.4.0) Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.4.0 Plugins and Packages
Projects
No open projects
Development

No branches or pull requests

1 participant